netdev
[Top] [All Lists]

Re: [RFC PATCH] Fix double dereference

To: davem@xxxxxxxxxxxxx
Subject: Re: [RFC PATCH] Fix double dereference
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Fri, 07 Jan 2005 18:30:39 +0900 (JST)
Cc: jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, herbert@xxxxxxxxxxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
In-reply-to: <20050106195333.2a90f6cb.davem@davemloft.net>
Organization: USAGI Project
References: <41DA3A60.8050102@pobox.com> <20050107.111806.27181187.yoshfuji@linux-ipv6.org> <20050106195333.2a90f6cb.davem@davemloft.net>
Sender: netdev-bounce@xxxxxxxxxxx
In article <20050106195333.2a90f6cb.davem@xxxxxxxxxxxxx> (at Thu, 6 Jan 2005 
19:53:33 -0800), "David S. Miller" <davem@xxxxxxxxxxxxx> says:

> On Fri, 07 Jan 2005 11:18:06 +0900 (JST)
> YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx> wrote:
> 
> > Am I miss something?
> 
> Does every path which destroys an ipv6 socket do the
> sk_dst_reset()?  If so, your patch should be valid.

Currently, inet6_destroy_sock() in net/ipv6/af_inet6.c, which is
called from udpv6_destory_sock() etc., takes care of this.
In that means, yes.

However, one for ipv4 doesn't do this.

I'll come up with new changesets.

Thanks.

--yoshfuji

<Prev in Thread] Current Thread [Next in Thread>