netdev
[Top] [All Lists]

Re: Patch: add loglevel to printk's in net/ipv4/route.c

To: Jesper Juhl <juhl-lkml@xxxxxx>
Subject: Re: Patch: add loglevel to printk's in net/ipv4/route.c
From: Herbert Poetzl <herbert@xxxxxxxxxxxx>
Date: Thu, 30 Dec 2004 03:12:39 +0100
Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>, Jörn Engel <joern@xxxxxxxxxxxxxxxxxxxx>, Networking Team <netdev@xxxxxxxxxxx>, linux-net <linux-net@xxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <Pine.LNX.4.61.0412300037310.3495@dragon.hygekrogen.localhost>
Mail-followup-to: Jesper Juhl <juhl-lkml@xxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>, Jörn Engel <joern@xxxxxxxxxxxxxxxxxxxx>, Networking Team <netdev@xxxxxxxxxxx>, linux-net <linux-net@xxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>
References: <Pine.LNX.4.61.0412290256000.3528@dragon.hygekrogen.localhost> <41D2104D.3010406@conectiva.com.br> <Pine.LNX.4.61.0412290312540.3528@dragon.hygekrogen.localhost> <41D2120E.8030008@conectiva.com.br> <20041229021256.GD29323@wohnheim.fh-wedel.de> <41D2152F.8080501@conectiva.com.br> <Pine.LNX.4.61.0412290344340.28589@dragon.hygekrogen.localhost> <Pine.LNX.4.61.0412300037310.3495@dragon.hygekrogen.localhost>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Thu, Dec 30, 2004 at 12:39:10AM +0100, Jesper Juhl wrote:
> On Wed, 29 Dec 2004, Jesper Juhl wrote:
> 
> > On Wed, 29 Dec 2004, Arnaldo Carvalho de Melo wrote:
> > 
> > > 
> > > 
> > > Jörn Engel wrote:
> > > > On Wed, 29 December 2004 00:10:22 -0200, Arnaldo Carvalho de Melo wrote:
> > > > 
> > > > > > It doesn't make much difference, it's mostly for
> > > > > > completeness/correctness.
> > > > > 
> > > > > No, it does a helluva difference, give it a try :-)
> > > > 
> > > > 
> > > > hint: look for "\n"
> > > 
> > > hint2: Or the _lack_ of "\n" 8)
> > > 
> > 
> > Ok, obviously something's wrong, but it's currently 03:44 here, so I'll 
> > take a look at it tomorrow (or quite possibly the day after since I have 
> > things to do).
> > Thank you for commenting, I'll dig into it at the first oppotunity I have.
> > 
> > 
> Ok, this is a bit embarresing. Looking at the patch now after getting some 
> sleep it's quite obvious that it is wrong. I should have slept on it 
> before sending it - sorry for the noise people.

nothing to be sorry about, and thanks for all
the work you are doing for the linux kernel ...

best,
Herbert

> -- 
> Jesper Juhl
> 
> 
> 
> 

<Prev in Thread] Current Thread [Next in Thread>