Re: [PATCH][v4][19/24] Add IPoIB (IP-over-InfiniBand) driver

[Arnd Bergmann <arnd@xxxxxxxx>]

On Maandag 20 Dezember 2004 07:58, YOSHIFUJI Hideaki / åèèæ wrote:
> Roland Dreier <roland@xxxxxxxxxxx> says:
> 
> > +enum {
> > +ÂÂÂÂÂIPOIB_PACKET_SIZE Â Â Â Â = 2048,
> > +ÂÂÂÂÂIPOIB_BUF_SIZE ÂÂÂÂÂÂÂÂÂ Â= IPOIB_PACKET_SIZE + 
> > IB_GRH_BYTES,
> > +
> > +ÂÂÂÂÂIPOIB_ENCAP_LEN ÂÂÂÂÂÂÂÂ Â= 4,
> > +
> > +ÂÂÂÂÂIPOIB_RX_RING_SIZE ÂÂÂÂÂ Â= 128,
> > +ÂÂÂÂÂIPOIB_TX_RING_SIZE ÂÂÂÂÂ Â= 64,
> > +
> 
> above entries does not seem to appropriate for enum (than #define).

According to Documentation/CodingStyle, it actually is preferred like this.
See also include/linux/ide.h for another example where this is done.

 Arnd <><