netdev
[Top] [All Lists]

Re: [2.6 patch] net/ipv6/: misc possible cleanups

To: bunk@xxxxxxxxx
Subject: Re: [2.6 patch] net/ipv6/: misc possible cleanups
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Wed, 15 Dec 2004 10:59:00 +0900 (JST)
Cc: netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
In-reply-to: <20041215005546.GA11972@stusta.de>
Organization: USAGI Project
References: <20041215005546.GA11972@stusta.de>
Sender: netdev-bounce@xxxxxxxxxxx
In article <20041215005546.GA11972@xxxxxxxxx> (at Wed, 15 Dec 2004 01:55:46 
+0100), Adrian Bunk <bunk@xxxxxxxxx> says:

> The patch below contains the following possible cleanups:
> - make some needlessly global code static
> - remove the following unused functions:
>   - exthdrs.c: ipv6_build_rthdr
>   - exthdrs.c: ipv6_build_exthdr
>   - exthdrs.c: ipv6_build_nfrag_opts
>   - exthdrs.c: ipv6_build_frag_opts
> - remove the following unused global variables:
>   - addrconf.c: in6addr_any
> - remove the following EXPORT_SYMBOL's:
>   - ipv6_syms.c: addrconf_lock
>   - ipv6_syms.c: in6addr_any
>   - ipv6_syms.c: in6addr_loopback
> 
> Please comment on which of these changes are correct and which conflict
> with pending patches.

Please keep addrconf_lock (for SCTP).
Please keep in6addr_any in addrconf.c (or enclose by #if 0 ... #endif)

> --- linux-2.6.10-rc3-mm1-full/include/net/ip.h.old    2004-12-14 
> 05:20:46.000000000 +0100
> +++ linux-2.6.10-rc3-mm1-full/include/net/ip.h        2004-12-14 
> 05:20:53.000000000 +0100
:

I think you attatched incorrect patch file.

--yoshfuji

<Prev in Thread] Current Thread [Next in Thread>