Re: [PATCH] netem: restart device after inserting packets

[Stephen Hemminger <shemminger@xxxxxxxx>]

On Fri, 10 Dec 2004 04:33:21 +0100
Patrick McHardy <kaber@xxxxxxxxx> wrote:

> David S. Miller wrote:
> 
> >On Wed, 8 Dec 2004 12:31:03 -0800
> >Stephen Hemminger <shemminger@xxxxxxxx> wrote:
> >  
> >
> >>The version of netem in 2.6.10 moves packets from the delayed queue
> >>to the qdisc in a timer interrupt. But it forgot to force the device to
> >>pick them up.
> >>
> >>Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxx>
> >>
> >
> >Good spotting.  Applied, thanks Stephen.
> >
> The patch is incomplete, netem may dequeue multiple packets from
> the delayed queue at once and feed them to the inner queue, but
> qdisc_restart will only dequeue one packet from the inner queue.
> This patch moves qdisc_run back to include/net/pkt_sched.h and
> replaces qdisc_restart by qdisc_run in netem_watchdog.

Yes, I wasn't running big enough delays to notice.