Re: [PATCH] PKT_SCHED: Prevent destroying via RTM

netdev

Re: [PATCH] PKT_SCHED: Prevent destroying via RTM_DELTFILTER while class

To:	Patrick McHardy <kaber@xxxxxxxxx>
Subject:	Re: [PATCH] PKT_SCHED: Prevent destroying via RTM_DELTFILTER while classifying
From:	Thomas Graf <tgraf@xxxxxxx>
Date:	Fri, 10 Dec 2004 13:29:57 +0100
Cc:	"David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to:	<41B9050A.1060401@trash.net>
References:	<20041210014322.GS1371@postel.suug.ch> <41B9050A.1060401@trash.net>
Sender:	netdev-bounce@xxxxxxxxxxx

> >The second path needs the spinlock to avoid destroying while
> >a classification is in progress. 2.4 probably needs the same fix,
> >I will cook one up if so.
> > 
> >
> This is not correct. The classifier is unlinked in tc_ctl_tfilter
> before it is destroyed, so it is not visible for classification anymore.

You're right. Thanks.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] PKT_SCHED: Prevent destroying via RTM_DELTFILTER while classifying, Thomas Graf Re: [PATCH] PKT_SCHED: Prevent destroying via RTM_DELTFILTER while classifying, Patrick McHardy Re: [PATCH] PKT_SCHED: Prevent destroying via RTM_DELTFILTER while classifying, Thomas Graf <=

Previous by Date:	analysing ip_rcv code problems, cranium2003
Next by Date:	Re: [PATCH] PKT_SCHED: Fix double locking in tcindex destroy path, Thomas Graf
Previous by Thread:	Re: [PATCH] PKT_SCHED: Prevent destroying via RTM_DELTFILTER while classifying, Patrick McHardy
Next by Thread:	[PATCH] PKT_SCHED: Fix double locking in tcindex destroy path, Thomas Graf
Indexes:	[Date] [Thread] [Top] [All Lists]