Re: [PATCH] PKT_SCHED: validate policer configuration TLVs

["David S. Miller" <davem@xxxxxxxxxxxxx>]

On Tue, 7 Dec 2004 18:23:49 +0100
Thomas Graf <tgraf@xxxxxxx> wrote:

> Adds TLV size sanity checks for policer configuration. 

Hmmm...

> -     if (tb[TCA_POLICE_RESULT-1])
> +     if (tb[TCA_POLICE_RESULT-1]) {
> +             if (RTA_PAYLOAD(tb[TCA_POLICE_RESULT-1]) != sizeof(u32))
> +                     goto failure;
>               p->result = *(int*)RTA_DATA(tb[TCA_POLICE_RESULT-1]);
> +     }

Either these things are int's or u32's, they cannot be both :-)
I know that size wise it's identical, but at least make the code
look consistent.