netdev
[Top] [All Lists]

Re: [PATCH] rtnetlink: link attribute modification by interface name

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: [PATCH] rtnetlink: link attribute modification by interface name
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Tue, 30 Nov 2004 22:28:13 -0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20041130220659.GK31969@postel.suug.ch>
References: <20041130220659.GK31969@postel.suug.ch>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 30 Nov 2004 23:06:59 +0100
Thomas Graf <tgraf@xxxxxxx> wrote:

> This patch allows modification of link attributes by the interface name,
> avoids the requirement of translating a name to an ifindex first, and
> provides better atomicity to userspace.  It works by setting the ifindex
> to a negative number and provide the interface name via the IFLA_IFNAME
> TLV and let the kernel lookup the device by name instead of ifindex. Changing
> the interface name will not work using this method because IFLA_IFNAME also
> transports the new interface name.  The patch also fixes a possible source for
> bugs if IFNAMSIZ is ever changed to a number not aligned to RTA_ALIGNTO.

Looks good, applied to my 2.6.11 pending tree.

Thanks.

<Prev in Thread] Current Thread [Next in Thread>