Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET

[Chris Wright <chrisw@xxxxxxxx>]

* Ross Kendall Axe (ross.axe@xxxxxxxxxxxxxxxx) wrote:
> Taking this idea further, couldn't we split unix_dgram_sendmsg into 2 
> functions, do_unix_dgram_sendmsg and do_unix_connectionless_sendmsg (and 
> similarly for unix_stream_sendmsg), then all we'd need is:
> 
> <pseudocode>
> static int do_unix_dgram_sendmsg(...);
> static int do_unix_stream_sendmsg(...);
> static int do_unix_connectionless_sendmsg(...);
> static int do_unix_connectional_sendmsg(...);

We could probably break it down to better functions and helpers, but I'm
not sure that's quite the breakdown.  That looks to me like an indirect
way to pass a flag which is already encoded in the ops and sk_type.
At anyrate, for 2.6.10 the changes should be small and obvious.
Better refactoring should be left for 2.6.11.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net