Re: [PATCH] (5/25) sk98: elimnate nested macro.

netdev

Re: [PATCH] (5/25) sk98: elimnate nested macro.

To:	Stephen Hemminger <shemminger@xxxxxxxx>
Subject:	Re: [PATCH] (5/25) sk98: elimnate nested macro.
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 16 Nov 2004 08:23:50 +0000
Cc:	Jeff Garzik <jgarzik@xxxxxxxxx>, Mirko Lindner <demon@xxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to:	<20041115152208.6684c483@zqx3.pdx.osdl.net>
References:	<20041115150910.0f3b8498@zqx3.pdx.osdl.net> <20041115152208.6684c483@zqx3.pdx.osdl.net>
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.4.1i

On Mon, Nov 15, 2004 at 03:22:08PM -0800, Stephen Hemminger wrote:
> Replace nested macros to handle defining 64bit constants with
> simpler macro. Would prefer to just remove it but it gets used in multiple
> OS common code.

I don't think the driver is complex enough for all that os-common mess.
If you look at the BSD sk driver it's about a third of the size of the
Linux driver because it doesn't have all this mess.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] (5/25) sk98: elimnate nested macro., Stephen Hemminger Re: [PATCH] (5/25) sk98: elimnate nested macro., Christoph Hellwig <=

Previous by Date:	Re: [PATCH] (4/25) sk98: change #define to typedef, Christoph Hellwig
Next by Date:	Re: [PATCH] remove bogus exports in ppp, Christoph Hellwig
Previous by Thread:	[PATCH] (5/25) sk98: elimnate nested macro., Stephen Hemminger
Next by Thread:	[PATCH] (1/25) sk98: skethtool elimnateCamelCaps, Stephen Hemminger
Indexes:	[Date] [Thread] [Top] [All Lists]