netdev
[Top] [All Lists]

[patch] 2.4.28-rc3: neigh_for_each must be EXPORT_SYMBOL'ed

To: Marcelo Tosatti <marcelo.tosatti@xxxxxxxxxxxx>, Harald Welte <laforge@xxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: [patch] 2.4.28-rc3: neigh_for_each must be EXPORT_SYMBOL'ed
From: Adrian Bunk <bunk@xxxxxxxxx>
Date: Sat, 13 Nov 2004 21:07:35 +0100
Cc: linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, patrick@xxxxxxxxxxxxxxx, linux-decnet-user@xxxxxxxxxxxxxxxxxxxxx
In-reply-to: <20041112180052.GE23215@logos.cnet>
References: <20041112180052.GE23215@logos.cnet>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
I'm getting the following error:

<--  snip  -->

depmod: *** Unresolved symbols in 
/lib/modules/2.4.28-rc3/kernel/net/decnet/decnet.o
depmod:         neigh_for_each

<--  snip  -->


This was caused by Harald's backport of the neighbour scalability fixes 
from 2.6 .


neigh_for_each must be EXPORT_SYMBOL'ed (as it is in 2.6):


Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

--- linux-2.4.28-rc3-modular/net/core/Makefile.old      2004-11-13 
19:40:36.000000000 +0100
+++ linux-2.4.28-rc3-modular/net/core/Makefile  2004-11-13 19:40:50.000000000 
+0100
@@ -9,7 +9,7 @@
 
 O_TARGET := core.o
 
-export-objs := netfilter.o profile.o ethtool.o
+export-objs := netfilter.o profile.o ethtool.o neighbour.o
 
 obj-y := sock.o skbuff.o iovec.o datagram.o scm.o
 
--- linux-2.4.28-rc3-modular/net/core/neighbour.c.old   2004-11-13 
19:35:26.000000000 +0100
+++ linux-2.4.28-rc3-modular/net/core/neighbour.c       2004-11-13 
19:35:59.000000000 +0100
@@ -1569,6 +1569,7 @@
        }
        read_unlock_bh(&tbl->lock);
 }
+EXPORT_SYMBOL(neigh_for_each);
 
 /* The tbl->lock must be held as a writer and BH disabled. */
 void __neigh_for_each_release(struct neigh_table *tbl,



<Prev in Thread] Current Thread [Next in Thread>