netdev
[Top] [All Lists]

[PATCH] (11/23) sk98: board counter incremented twice

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: [PATCH] (11/23) sk98: board counter incremented twice
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Thu, 11 Nov 2004 15:57:53 -0800
Cc: Michael Heyse <mhk@xxxxxxxxxxxxxxxxx>, Mirko Lindner <mlindner@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20041111154225.5cf85567@zqx3.pdx.osdl.net>
Organization: Open Source Development Lab
References: <4192C60A.1050205@designassembly.de> <20041111154225.5cf85567@zqx3.pdx.osdl.net>
Sender: netdev-bounce@xxxxxxxxxxx
Minor bug, bourd found incremented twice. Also don't need to
initialize fields already zerod.

Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxx>

diff -Nru a/drivers/net/sk98lin/skge.c b/drivers/net/sk98lin/skge.c
--- a/drivers/net/sk98lin/skge.c        2004-11-03 15:09:28 -08:00
+++ b/drivers/net/sk98lin/skge.c        2004-11-03 15:09:28 -08:00
@@ -4972,11 +4972,6 @@
        }
 #endif
 
-       pNet->PortNr = 0;
-       pNet->NetNr  = 0;
-
-       boards_found++;
-
        /* More then one port found */
        if ((pAC->GIni.GIMacsFound == 2 ) && (pAC->RlmtNets == 2)) {
                if ((dev = alloc_etherdev(sizeof(DEV_NET))) == 0) {

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] (11/23) sk98: board counter incremented twice, Stephen Hemminger <=