netdev
[Top] [All Lists]

[PATCH] (2/23) sk98: local variable can be constant

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: [PATCH] (2/23) sk98: local variable can be constant
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Thu, 11 Nov 2004 15:53:36 -0800
Cc: Michael Heyse <mhk@xxxxxxxxxxxxxxxxx>, Mirko Lindner <mlindner@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20041111154225.5cf85567@zqx3.pdx.osdl.net>
Organization: Open Source Development Lab
References: <4192C60A.1050205@designassembly.de> <20041111154225.5cf85567@zqx3.pdx.osdl.net>
Sender: netdev-bounce@xxxxxxxxxxx
The table OnesHash is only used in this file, and should
be made a local constant.

Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxx>

diff -Nru a/drivers/net/sk98lin/skaddr.c b/drivers/net/sk98lin/skaddr.c
--- a/drivers/net/sk98lin/skaddr.c      2004-11-03 14:07:28 -08:00
+++ b/drivers/net/sk98lin/skaddr.c      2004-11-03 14:07:28 -08:00
@@ -79,7 +79,7 @@
 
 /* 64-bit hash values with all bits set. */
 
-SK_U16 OnesHash[4] = {0xFFFF, 0xFFFF, 0xFFFF, 0xFFFF};
+static const SK_U16    OnesHash[4] = {0xFFFF, 0xFFFF, 0xFFFF, 0xFFFF};
 
 /* local variables 
************************************************************/
 

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] (2/23) sk98: local variable can be constant, Stephen Hemminger <=