netdev
[Top] [All Lists]

Re: [PATCH] [TRY2] Use nfmark as a key in u32 classifier

To: "Catalin(ux aka Dino) BOIE" <util@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH] [TRY2] Use nfmark as a key in u32 classifier
From: Thomas Graf <tgraf@xxxxxxx>
Date: Tue, 9 Nov 2004 14:30:35 +0100
Cc: linux-net@xxxxxxxxxxxxxxx, lartc@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <Pine.LNX.4.61.0411091406570.20094@webhosting.rdsbv.ro>
Mail-followup-to: "Catalin(ux aka Dino) BOIE" <util@xxxxxxxxxxxxxxx>, linux-net@xxxxxxxxxxxxxxx, lartc@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
References: <Pine.LNX.4.61.0411091406570.20094@webhosting.rdsbv.ro>
Sender: netdev-bounce@xxxxxxxxxxx
* Catalin(ux aka Dino) BOIE 
<Pine.LNX.4.61.0411091406570.20094@xxxxxxxxxxxxxxxxxxx> 2004-11-09 14:27
> This is the try number two.
> What was changed:
> - Added selectable choice in Kconfig file (thanks Jamal!)
> - Don't abuse tc_u32_sel to not break backward compatibility (thanks 
> Patrick!).

Your patchs looks fine except for missing dependcy on CONFIG_NETFILTER.
Either make CLS_U32_MARK dependant on it or #ifdef the references
to skb->nfmark.

It might be fair to tell you that this code is likely to be removed
again once we have the metadata match.

Cheers

<Prev in Thread] Current Thread [Next in Thread>