Re: [PATCH] PKT_SCHED: Initialize list field in dummy qdiscs

[Thomas Graf <tgraf@xxxxxxx>]

> Who cares about huge sections while holding reference counts ?
> qdisc_destroy won't destroy the qdisc until all references have
> been dropped, that's the whole point of it.

I might have misunderstood you in this point, so you increment a
refcnt in qdisc_lookup and decrement in once you're done with
the reference? I thought you wanted to to bh spin locks. I'm not
sure how you want to do this without creating races.

Example:

We get a RTM_DELQDISC request so you'll increment refcnt in
qdisc_lookup and decrement it right before you call qdisc_destroy
so it actually can be deleted. The rcu callback works fine
and will set up a another rcu callback for the destroying of
the inner qdiscs. Right at this time you get a RTM_GETQDISC for
that inner qdisc so you'll lock on it, then the rcu callback
comes in and cannot delete the inner qdisc anymore. Do you want
to sleep in softirq context?