Re: [PATCH] PKT_SCHED: Initialize list field in dummy qdiscs

[Thomas Graf <tgraf@xxxxxxx>]

* Patrick McHardy <418C2D40.9020300@xxxxxxxxx> 2004-11-06 02:47
> Nice work, I was really beginning to wonder. There's not that
> much that touches qdisc_list :)

Which might have been the problem, I've been focusing on this for
hours overlooking the obvious. The bug report was very well done,
maybe too good so I was at the root of the problem too fast. ;->

> The __qdisc_destroy rcu-callback is called in softirq context, when
> destroying a classful qdisc the qdisc destroy function might call
> qdisc_destroy again for an inner class.

Ahh... of course. I was looking through all callers of destroy multiple
times but somehow I managed to overlook the one in __qdisc_destroy
over and over.  Thanks!

> >I guess I'm missing that little bit of experience but it would
> >help to use _rcu list variantes, would it?
> >
> Yes. Are you going to send a patch ?

Sure, tomorrow, if nobody preempts. I need some rest.