Re: [PATCH 2/3] r8169: Large Send enablement

[Jon Mason <jdmason@xxxxxxxxxx>]

On Thursday 04 November 2004 06:45 pm, Francois Romieu wrote:
> Jon Mason <jdmason@xxxxxxxxxx> :
> > On Tuesday 02 November 2004 01:11 pm, Francois Romieu wrote:
> > [...]
> >
> > > - If rtl8169_open() fails [*] when the device was previously up, the
> > > driver could/should try to recover.
> >
> > I disagree.  It should fail, complain loudly, and let the user try and
> > fix it (or return it to the previous state).  The code provided below
> > will act like
>
> Mmmm... Actually both patches try to paper over the real issue: the driver
> should reserve the resources it needs for the change of mtu first.

Agreed.  I did a quick look in the other drivers, and didn't find any drivers 
that handle this possibility.  Most of them ignore the fact.  This sounds 
like an open hole in all of the drivers.