Re: [NET] Fix neighbour tbl->entries race

[YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>]

In article <20041102210259.GA12642@xxxxxxxxxxxxxxxxxxx> (at Wed, 3 Nov 2004 
08:02:59 +1100), Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> says:

> -     if (tbl->entries > tbl->gc_thresh3 ||
> -         (tbl->entries > tbl->gc_thresh2 &&
> +     entries = atomic_inc_return(&tbl->entries) - 1;
> +     if (entries >= tbl->gc_thresh3 ||
> +         (entries >= tbl->gc_thresh2 &&

Why don't you do something like this?

        entries = atomic_inc_return(&tbl->entries);
        if (entries > tbl->gc_thresh3 ||
            (entries > tbl->gc_thresh2 &&

--yoshfuji