Re: [NET] Fix neighbour tbl->entries race

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Tue, Nov 02, 2004 at 09:13:43AM -0500, jamal wrote:
> 
> Is this still the same logic:
> 
> -------------
> -               if (!neigh_forced_gc(tbl) &&
> -                   tbl->entries > tbl->gc_thresh3)
> -                       goto out;
> +               neigh_forced_gc(tbl);
> +               if (atomic_read(&tbl->entries) > tbl->gc_thresh3)
> +                       goto out_entries;
> 
> -------
> 
> In previous code it seems you should short-circuit if
> neigh_forced_gc(tbl) returns non-zero. why do you have to break that
> if statement?

The previous logic is slightly incorrect in that even if neigh_forced_gc
succeeded in removing some entries, the total number of entries may still
be above the threshold 3.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt