| To: | Jon Mason <jdmason@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/3] r8169: clean up |
| From: | Thomas Graf <tgraf@xxxxxxx> |
| Date: | Tue, 2 Nov 2004 20:55:03 +0100 |
| Cc: | Francois Romieu <romieu@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, jgarzik@xxxxxxxxx |
| In-reply-to: | <200411021347.39047.jdmason@us.ibm.com> |
| References: | <200411021203.25100.jdmason@us.ibm.com> <20041102192746.GB24860@electric-eye.fr.zoreil.com> <200411021347.39047.jdmason@us.ibm.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
> > > 0; - cmd->autoneg = !!(status & TBINwEnable); > > > + cmd->autoneg = status & TBINwEnable; > Silly question, does "!!" not execute a bitwise not twice? If not, then > please forgive my ignorance. Yes but the result is not the same, the result will be either 1 or 0 if done with !! and yours will result in TBINwEnable or 0. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/3] r8169: Large Send enablement, Jeff Garzik |
|---|---|
| Next by Date: | Re: [PATCH 2.6] e100, e1000, ixgb: add MODULE_VERSION tags, John W. Linville |
| Previous by Thread: | Re: [PATCH 3/3] r8169: clean up, Jon Mason |
| Next by Thread: | Re: [PATCH 3/3] r8169: clean up, Francois Romieu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |