netdev
[Top] [All Lists]

Re: [patch 06/18] net/cosa: replace schedule_timeout() with msleep_int

To: Jan Kasprzak <kas@xxxxxxxxxx>
Subject: Re: [patch 06/18] net/cosa: replace schedule_timeout() with msleep_interruptible()
From: Nishanth Aravamudan <nacc@xxxxxxxxxx>
Date: Mon, 1 Nov 2004 14:00:07 -0800
Cc: Jeff Garzik <jgarzik@xxxxxxxxx>, janitor@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20041101112313.GD12416@fi.muni.cz>
References: <E1CO1vg-00027C-CO@sputnik> <4184C79F.3090602@pobox.com> <20041101112313.GD12416@fi.muni.cz>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Mon, Nov 01, 2004 at 12:23:14PM +0100, Jan Kasprzak wrote:
> Jeff Garzik wrote:
> : why add all the memory barriers and such associated with 
> : set_current_state() ?
> : 
>       This is not time-critical - COSA is an ISA-only device,
> and the driver is not tested on SMP (I have tried to make it SMP-aware,
> but at the time I had no SMP machine with ISA slot).

Just to make it clear, then, the current patch is ok? Or would you
prefer I had used __set_current_state()?

-Nish

<Prev in Thread] Current Thread [Next in Thread>