| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH netdev-2.6 7/10] ixgb: Replace kmalloc with vmalloc to allocate driver local data structures |
| From: | William Lee Irwin III <wli@xxxxxxxxxxxxxx> |
| Date: | Fri, 29 Oct 2004 11:29:26 -0700 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, "Venkatesan, Ganesh" <ganesh.venkatesan@xxxxxxxxx>, netdev <netdev@xxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx> |
| In-reply-to: | <41828B5D.7090908@pobox.com> |
| Organization: | The Domain of Holomorphy |
| References: | <468F3FDA28AA87429AD807992E22D07E0312853C@orsmsx408> <20041029130817.GA12301@infradead.org> <418277B7.7000705@pobox.com> <20041029173636.GB12934@holomorphy.com> <41828B5D.7090908@pobox.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040722i |
William Lee Irwin III wrote: >> vmalloc is relatively highly penalized. For instance, global TLB >> flushes associated with vfree() and so on. Aggregate vmallocspace >> limitations are a big concern. I probably wouldn't use vmallocspace >> for much besides infrequent allocations, e.g. things allocated during >> driver initialization. One per driver instance won't really hurt much >> because vmallocspace limits prevent large numbers of drivers from being >> simultaneously loaded as it stands now anyway. On Fri, Oct 29, 2004 at 02:26:37PM -0400, Jeff Garzik wrote: > That's precisely what we're contemplating -- a once per driver > allocation that remains static for the entire driver runtime (descriptors) An infrastructural change that does this would probably need to be considered more carefully. I think you can probably just do it. -- wli |
| Previous by Date: | Re: [PATCH netdev-2.6 7/10] ixgb: Replace kmalloc with vmalloc to allocate driver local data structures, Jeff Garzik |
|---|---|
| Next by Date: | Re: net: generic netdev_ioaddr, Pekka J Enberg |
| Previous by Thread: | Re: [PATCH netdev-2.6 7/10] ixgb: Replace kmalloc with vmalloc to allocate driver local data structures, Jeff Garzik |
| Next by Thread: | RE: [PATCH netdev-2.6 7/10] ixgb: Replace kmalloc with vmalloc to allocate driver local data structures, Venkatesan, Ganesh |
| Indexes: | [Date] [Thread] [Top] [All Lists] |