On Fri, 29 Oct 2004 19:43:09 +0200
Mirko Lindner <mlindner@xxxxxxxxxxxxx> wrote:
> Stephen,
>
> thank You for the help! Should we help you in any case to check or
> change the defines?
>
> We have the problem that the Linux driver consists of multiple files
> which are also used for other drivers running on other OSes
> (e.g. Sun, HP-UX, MacOS X, *BSD, Windows, PXE, AIX, Unixware...).
>
> This is for instance the reason why we must use redefines for the
> different data types (e.g. SK_U32). Can you please explain what you mean
> with "UglyReDefineTheWorld"? Are there any special defines you do not
> like? I am wondering why the style plays such an important role when
> looking at the driver source. I am not sure what redefines you are
> referring to, but the datatype redefines for example have been in the
> kernel tree for years without any complains.
Style matters especially things like:
#define SK_NET_DEVICE net_device
#define SK_IOC char __iomem *
because it means that source code inspection tools like cscope will
not easily pickup all usages of the structure when developers need to
do audit's to change interfaces.
My goal is to make all the linux only pieces look as close to linux style
as possible without going to the extreme of changing variable names and
function names.
The common parts will not be touched at all. My plan will be to make
one of the patch steps up these in one chunk.
> If you could send us a list about the requested changes you'd like to
> perform, we can help you or provide additional support. We would really
> appreciate it, if you could inform us in advance about those changes,
> because the driver was tested extensively in our test&verification
> department and by a considerably amount of OEM vendors. Changing now
> parts of the code may break the driver functionality or the
> functionality of the driver files used on other OSes.
>
> Cheers
> Mirko
So far I have about 10 patches done, and most of the way through getting ethtool
working using your code. EMany ethtool functions needed minor work to resolve
issues like not checking parameters and error handling.
|