netdev
[Top] [All Lists]

Re: [patch 9/9] Avoid warning on CONNTRACK_STAT_INC in destroy_conntrack

To: akpm@xxxxxxxx
Subject: Re: [patch 9/9] Avoid warning on CONNTRACK_STAT_INC in destroy_conntrack()
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Thu, 28 Oct 2004 16:49:56 -0700
Cc: jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, akpm@xxxxxxxx, rusty@xxxxxxxxxxxxxxx
In-reply-to: <200410280721.i9S7Ll908021@mail.osdl.org>
References: <200410280721.i9S7Ll908021@mail.osdl.org>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 28 Oct 2004 00:19:48 -0700
akpm@xxxxxxxx wrote:

> From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> 
> ip_conntrack_put can be called in any context in theory: in particular,
> MASQUERADE will can call it (via ip_ct_selective_cleanup) when an interface
> comes up with a different address.
> 
> Move the CONNTRACK_STAT_INC inside the lock: it needs preemption disabled.
> 
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxx>

Applied, thanks.

<Prev in Thread] Current Thread [Next in Thread>