Re: [patch 3/9] use mmiowb in tg3

netdev

Re: [patch 3/9] use mmiowb in tg3_poll

To:	akpm@xxxxxxxx
Subject:	Re: [patch 3/9] use mmiowb in tg3_poll
From:	"David S. Miller" <davem@xxxxxxxxxxxxx>
Date:	Thu, 28 Oct 2004 16:43:38 -0700
Cc:	jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, akpm@xxxxxxxx, akepner@xxxxxxx
In-reply-to:	<200410280721.i9S7Le907988@mail.osdl.org>
References:	<200410280721.i9S7Le907988@mail.osdl.org>
Sender:	netdev-bounce@xxxxxxxxxxx

On Thu, 28 Oct 2004 00:19:41 -0700
akpm@xxxxxxxx wrote:

> From: <akepner@xxxxxxx>
> 
> Returning from tg3_poll() without flushing the PIO write which reenables
> interrupts can result in lower cpu utilization and higher throughput.  So
> use a memory barrier, mmiowb(), instead of flushing the write with a PIO
> read.
> 
> Signed-off-by: Arthur Kepner <akepner@xxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxx>

Also applied, thanks.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[patch 3/9] use mmiowb in tg3_poll, akpm Re: [patch 3/9] use mmiowb in tg3_poll, David S. Miller <=

Previous by Date:	Re: [patch 2/9] use mmiowb in tg3.c, David S. Miller
Next by Date:	Re: [patch 4/9] X.25: Stop x25_destroy_socket timer looping, David S. Miller
Previous by Thread:	[patch 3/9] use mmiowb in tg3_poll, akpm
Next by Thread:	[patch 5/9] ethertap debug no newline, akpm
Indexes:	[Date] [Thread] [Top] [All Lists]