Re: [PATCH 9/11] PKT_SCHED: Cleanup cls_set

To:	Thomas Graf <tgraf@xxxxxxx>
Subject:	Re: [PATCH 9/11] PKT_SCHED: Cleanup cls_set_class
From:	"David S. Miller" <davem@xxxxxxxxxxxxx>
Date:	Wed, 27 Oct 2004 14:38:19 -0700
Cc:	tommy.christensen@xxxxxxxxx, netdev@xxxxxxxxxxx, hadi@xxxxxxxxxx
In-reply-to:	<20041027094238.GM12289@postel.suug.ch>
References:	<20041026222148.GA12289@postel.suug.ch> <20041026222813.GJ12289@postel.suug.ch> <1098867450.1813.37.camel@cyan.cph.tpack.net> <20041027094238.GM12289@postel.suug.ch>
Sender:	netdev-bounce@xxxxxxxxxxx

On Wed, 27 Oct 2004 11:42:38 +0200
Thomas Graf <tgraf@xxxxxxx> wrote:

> > This locks once too many.
> > (And it returns an *unsigned* long.)
> 
> Thanks. I wonder how this lock could get in there.
> 
> 
> Remove bogus lock and make cls_set_class return unsigned long.
> 
> Signed-off-by: Thomas Graf <tgraf@xxxxxxx>

Applied, thanks.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 3/11] PKT_SCHED: Remove obsolete definitions in pkt_cls.h, (continued) [PATCH 3/11] PKT_SCHED: Remove obsolete definitions in pkt_cls.h, Thomas Graf [PATCH 4/11] PKT_SCHED: Add net/act_api.h with public action/policer bits, Thomas Graf [PATCH 5/11] PKT_SCHED: Remove obsolete definitions in pkt_sched.h, Thomas Graf [PATCH 6/11] PKT_SCHED: Transform prototypes to be extern, Thomas Graf [PATCH 7/11] PKT_SCHED: Move tc_classify from pkt_cls.h to sch_api.c, Thomas Graf *[PATCH 8/11] PKT_SCHED: psched__per_* can be static*, Thomas Graf* [PATCH 9/11] PKT_SCHED: Cleanup cls_set_class, Thomas Graf Re: [PATCH 9/11] PKT_SCHED: Cleanup cls_set_class, Tommy Christensen Re: [PATCH 9/11] PKT_SCHED: Cleanup cls_set_class, Thomas Graf Re: [PATCH 9/11] PKT_SCHED: Cleanup cls_set_class, Thomas Graf Re: [PATCH 9/11] PKT_SCHED: Cleanup cls_set_class, David S. Miller <= [PATCH 10/11] PKT_SCHED: Inline psched_tod_diff, Thomas Graf [PATCH 11/11]: PKT_SCHED: Use new header architecture, Thomas Graf Re: [PATCHSET 0/11] PKT_SCHED: overall net/pkt_cls.h and net/pkt_sched.h cleanup, David S. Miller

Previous by Date:	Re: [2.6.10-rc1-bk5] e1000 broken badly on IBM T42, Shawn Starr
Next by Date:	Re: [PATCH 2.6] fix NLM_F_MULTI in tcp_diag and xfrm_user (was Re: BTW), David S. Miller
Previous by Thread:	Re: [PATCH 9/11] PKT_SCHED: Cleanup cls_set_class, Thomas Graf
Next by Thread:	[PATCH 10/11] PKT_SCHED: Inline psched_tod_diff, Thomas Graf
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 9/11] PKT_SCHED: Cleanup cls_set_class