Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Tue, Oct 26, 2004 at 07:54:35PM -0400, Jeff Garzik wrote:
> Herbert Xu wrote:
> >+static int __ethtool_set_sg(struct net_device *dev, u32 data)
> >+{
> >+    int err;
> >+
> >+    if (!data && dev->ethtool_ops->set_tso) {
> >+            err = dev->ethtool_ops->set_tso(dev, 0);
> >+            if (err)
> >+                    return err;
> >+    }
> >+
> >+    return dev->ethtool_ops->set_sg(dev, data);
> >+}
> 
> you want to disable tx-csum also

IMHO it is valid to disable SG without disabling checksums, no?
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt