| To: | Francois Romieu <romieu@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [patch netdev-2.6 0/2] r8169: vlan hwaccel fixes |
| From: | "John W. Linville" <linville@xxxxxxxxxxxxx> |
| Date: | Fri, 22 Oct 2004 21:51:12 -0400 |
| Cc: | netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, jgarzik@xxxxxxxxx |
| In-reply-to: | <20041022202851.GB4216@electric-eye.fr.zoreil.com> |
| Mail-followup-to: | Francois Romieu <romieu@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, jgarzik@xxxxxxxxx |
| References: | <20041022005737.GA1945@tuxdriver.com> <20041022202851.GB4216@electric-eye.fr.zoreil.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.1i |
On Fri, Oct 22, 2004 at 10:28:51PM +0200, Francois Romieu wrote: > John W. Linville <linville@xxxxxxxxxxxxx> : > > Patch 2: > [nice explanation] > > Any objection against me replacing the actual comment of patch #2 (i.e. > "why" instead of "how") and splitting the "if ((tp->>vlgrp = grp))" over > two lines ? Not quite sure which comment you mean, but I'm sure that's fine. I posted a third patch to fix-up that tricky if() -- you're right, it is a little TOO clever... :-) John -- John W. Linville linville@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [patch netdev-2.6 3/3] r8169: simplify trick if() expression, John W. Linville |
|---|---|
| Next by Date: | Re: TCP crashes when cycling loopback interface., James Morris |
| Previous by Thread: | [patch netdev-2.6 3/3] r8169: simplify trick if() expression, John W. Linville |
| Next by Thread: | [PATCH] trivial speeling fix in net/sched/Kconfig, Chris Wright |
| Indexes: | [Date] [Thread] [Top] [All Lists] |