On Sat, Oct 23, 2004 at 07:50:40AM +1000, herbert wrote:
>
> So we don't really know whether it went further or not :)
Actually, I think we've caught your crash now. If that code path
is triggering at all, then it'll trigger with TSO packets too. If
we get a truly partial ack on a TSO packet, then tcp_tso_acked will
not trim it off. So we will fall through to this last-ditch trim
call, which doesn't update packets_out.
There are two solutions to this problem. I've taken the simpler
approach for now. We simply trim off the partial bits in tcp_tso_acked
and live with the fact that the packet counters may differ from
what's on the netwrok by one.
Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Later on we can "fix" this by remembering where the original TSO
packet started from, perhaps in skb->h or somewhere. Dave, is this
worth it?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
p
Description: Text document
|