netdev
[Top] [All Lists]

Re: 2.6.9 failed assertion in tcp_timer.c

To: Phil Oester <kernel@xxxxxxxxxxxx>
Subject: Re: 2.6.9 failed assertion in tcp_timer.c
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 23 Oct 2004 07:50:40 +1000
Cc: linux-net@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>
In-reply-to: <20041022185435.GA30709@linuxace.com>
References: <20041019215054.GA17565@linuxace.com> <E1CK3Az-0004P2-00@gondolin.me.apana.org.au> <20041020164748.GA20905@linuxace.com> <20041020212651.GA8534@gondor.apana.org.au> <20041020225536.GA22179@linuxace.com> <20041021130339.GA19345@gondor.apana.org.au> <20041021165224.GA25399@linuxace.com> <20041021215743.GA23062@gondor.apana.org.au> <20041022185435.GA30709@linuxace.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Fri, Oct 22, 2004 at 11:54:35AM -0700, Phil Oester wrote:
> 
> This patch gets it a bit further, but still panics (divide by 0?):

Oops, I forgot that this gets called on non-TSO packets as well.
So we don't really know whether it went further or not :)

We should only set the TSO size if the packet was TSO to start with.

Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>