netdev
[Top] [All Lists]

Re: [PATCH] Make netif_rx_ni preempt-safe

To: Lee Revell <rlrevell@xxxxxxxxxxx>
Subject: Re: [PATCH] Make netif_rx_ni preempt-safe
From: Denis Vlasenko <vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 20 Oct 2004 23:32:33 +0300
Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxxxxxx, maxk@xxxxxxxxxxxx, irda-users@xxxxxxxxxxxxxxxxxxxxx, Linux Network Development <netdev@xxxxxxxxxxx>, Alain Schroeder <alain@xxxxxxxxxxxxxxx>
In-reply-to: <1098303951.2268.8.camel@krustophenia.net>
References: <1098230132.23628.28.camel@krustophenia.net> <200410202256.56636.vda@port.imtp.ilyichevsk.odessa.ua> <1098303951.2268.8.camel@krustophenia.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.5.4
On Wednesday 20 October 2004 23:25, Lee Revell wrote:
> > > --- include/linux/netdevice.h~    2004-10-20 15:51:00.000000000 -0400
> > > +++ include/linux/netdevice.h     2004-10-20 15:51:54.000000000 -0400
> > > @@ -694,11 +694,14 @@
> > >  /* Post buffer to the network code from _non interrupt_ context.
> > >   * see net/core/dev.c for netif_rx description.
> > >   */
> > > -static inline int netif_rx_ni(struct sk_buff *skb)
> > > +static int netif_rx_ni(struct sk_buff *skb)
> > 
> > non-inline functions must not live in .h files
> 
> Where do you suggest we put it?

Somewhere near this place:

http://lxr.linux.no/source/net/core/dev.c?v=2.6.8.1#L1555
--
vda


<Prev in Thread] Current Thread [Next in Thread>