| To: | Patrick McHardy <kaber@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2.6]: Fix policy update bug when increasing priority of last policy |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Wed, 20 Oct 2004 22:05:58 -0700 |
| Cc: | herbert@xxxxxxxxxxxxxxxxxxx, davem@xxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <4175238C.7010907@trash.net> |
| References: | <E1CJhER-0001vk-00@gondolin.me.apana.org.au> <4175238C.7010907@trash.net> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Tue, 19 Oct 2004 16:24:12 +0200 Patrick McHardy <kaber@xxxxxxxxx> wrote: > Herbert Xu wrote: > > >Patrick McHardy <kaber@xxxxxxxxx> wrote: > > > >>This patch checks for *p != NULL before continuing the loop. > >> > >> > > > >Unfortunately that doesn't fix it completely. The real bug is > >the fact that we continue with a bogus p pointing to the deleted > >element. So what we should do is continue without updating p > >at all. > > > > > You're right, your patch is better. I've tested > it and it works fine. I applied Herbert's version of the fix, thanks guys. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [XFRM] Allow transport SAs even when there is no policy, David S. Miller |
|---|---|
| Next by Date: | Re: [PATCH][ATM]: use RCV_SHUTDOWN to exit skb_recv_datagram(), David S. Miller |
| Previous by Thread: | Re: [PATCH 2.6]: Fix policy update bug when increasing priority of last policy, Patrick McHardy |
| Next by Thread: | [PATCH][ATM]: use RCV_SHUTDOWN to exit skb_recv_datagram(), chas williams (contractor) |
| Indexes: | [Date] [Thread] [Top] [All Lists] |