netdev
[Top] [All Lists]

Re: [PATCH 2.6.9] Export phys_cpu_present_map

To: Tom Rini <trini@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 2.6.9] Export phys_cpu_present_map
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 20 Oct 2004 19:49:05 +0200
Cc: linux-mips@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20041020171626.GG12544@smtp.west.cox.net>
References: <20041020171626.GG12544@smtp.west.cox.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Wed, Oct 20, 2004 at 10:16:26AM -0700, Tom Rini wrote:
> In net/ipv6/icmp.c::icmpv6_init() there is a call to cpu_possible()
> which preprocesses down to "test_bit(((i)), (phys_cpu_present_map).bits)"
> If ipv6 is a module, phys_cpu_present_map (or cpu_possible_map which is
> defined t phys_cpu_present_map) needs to be exported.

The loop in there should be rewritten as for_each_cpu which doesn't need
this export.


<Prev in Thread] Current Thread [Next in Thread>