netdev
[Top] [All Lists]

Re: [PATCH] Make netif_rx_ni preempt-safe

To: Lee Revell <rlrevell@xxxxxxxxxxx>
Subject: Re: [PATCH] Make netif_rx_ni preempt-safe
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 20 Oct 2004 10:00:09 +1000
Cc: Andrew Morton <akpm@xxxxxxxx>, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxxxxxx, maxk@xxxxxxxxxxxx, irda-users@xxxxxxxxxxxxxxxxxxxxx, Linux Network Development <netdev@xxxxxxxxxxx>, Alain Schroeder <alain@xxxxxxxxxxxxxxx>
In-reply-to: <1098230132.23628.28.camel@krustophenia.net>
References: <1098230132.23628.28.camel@krustophenia.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Tue, Oct 19, 2004 at 07:55:33PM -0400, Lee Revell wrote:
> 
> --- include/linux/netdevice.h~        2004-10-19 18:50:18.000000000 -0400
> +++ include/linux/netdevice.h 2004-10-19 18:51:01.000000000 -0400
> @@ -696,9 +696,11 @@
>   */
>  static inline int netif_rx_ni(struct sk_buff *skb)
>  {
> +       preempt_disable();
>         int err = netif_rx(skb);

This is broken on older compilers.
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>