| To: | Thomas Graf <tgraf@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2.6.9 2/3] tlan: inline functions should be static + bogus xor |
| From: | Stephen Hemminger <shemminger@xxxxxxxx> |
| Date: | Tue, 19 Oct 2004 11:16:51 -0700 |
| Cc: | Jeff Garzik <jgarzik@xxxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <20041019003816.GG19714@rei.reeler.org> |
| Organization: | Open Source Development Lab |
| References: | <20041018140610.6edf1769@zqx3.pdx.osdl.net> <20041019003816.GG19714@rei.reeler.org> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Tue, 19 Oct 2004 02:38:16 +0200 Thomas Graf <tgraf@xxxxxxx> wrote: > > - return ( ( a && ! b ) || ( ! a && b ) ); > > + return a ^ b; > > Did you notice that this leads to a different result if a > or b is greater than 1. Intended? I am redoing the tlan patch series. There is actually a better implementation of the mcast hash already in the code but #ifdef'd out. Tested it and it generates the same values. So the whole old xor code just goes away... |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: NFS and Network Driver Question, Bob Wirka |
|---|---|
| Next by Date: | [PATCH][LSM] remove net related includes from security.h, Arnaldo Carvalho de Melo |
| Previous by Thread: | Re: [PATCH 2.6.9 2/3] tlan: inline functions should be static + bogus xor, Thomas Graf |
| Next by Thread: | [PATCH 2.6.9 3/5] skge: proc code cleanup, Stephen Hemminger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |