netdev
[Top] [All Lists]

Re: r8169: page allocation failure

To: Francois Romieu <romieu@xxxxxxxxxxxxx>
Subject: Re: r8169: page allocation failure
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 17 Oct 2004 19:08:37 +1000
Cc: jkillius@xxxxxxxx, netdev@xxxxxxxxxxx, davem@xxxxxxxxxxxxx, jgarzik@xxxxxxxxx
In-reply-to: <E1CJ5lg-0005eC-00@gondolin.me.apana.org.au>
References: <20041016204848.GB21849@electric-eye.fr.zoreil.com> <E1CJ5lg-0005eC-00@gondolin.me.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Sun, Oct 17, 2004 at 05:47:52PM +1000, Herbert Xu wrote:
> 
> It should instead allocate a new skb of 1 mss.  I'll work on it.

In fact it was allocating space that it wasn't even using :)

The following patch makes it allocate skb_headlen(skb) - len instead
of skb->len - len.  When skb is linear there is no difference.  When
it's non-linear we only ever copy the bytes in the header.

Please let me know whether this fixes your problem.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>