netdev
[Top] [All Lists]

RE: [PATCH 2.6.9-rc2 8/8] S2io: two buffer mode

To: "'Jeff Garzik'" <jgarzik@xxxxxxxxx>, "'Leonid Grossman'" <leonid.grossman@xxxxxxxx>
Subject: RE: [PATCH 2.6.9-rc2 8/8] S2io: two buffer mode
From: "Raghavendra Koushik" <raghavendra.koushik@xxxxxxxx>
Date: Fri, 15 Oct 2004 16:14:49 -0700
Cc: "'Chris Leech'" <chris.leech@xxxxxxxxx>, <ravinandan.arakali@xxxxxxxx>, "'Francois Romieu'" <romieu@xxxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>, <rapuru.sriram@xxxxxxxx>
In-reply-to: <41701B3C.8020006@pobox.com>
Sender: netdev-bounce@xxxxxxxxxxx
Thread-index: AcSy53Jq086kYiA2SbGuPqD/j8iuGwAIXf0A
Jeff,
 In this submission I'll use copy for 2Buff mode, but continue to debug the
fragmented skb Rx. If we do get it working sometime, I'll submit another
patch to update the driver. Is this Ok?

- Koushik

> -----Original Message-----
> From: Jeff Garzik [mailto:jgarzik@xxxxxxxxx]
> Sent: Friday, October 15, 2004 11:47 AM
> To: Leonid Grossman
> Cc: 'Raghavendra Koushik'; 'Chris Leech'; ravinandan.arakali@xxxxxxxx;
> 'Francois Romieu'; netdev@xxxxxxxxxxx; rapuru.sriram@xxxxxxxx
> Subject: Re: [PATCH 2.6.9-rc2 8/8] S2io: two buffer mode
> 
> Leonid Grossman wrote:
> >  "fragmented SKB on Rx" is an old problem - we tried to deploy 2 and 5
> > buffer Xframe modes before and it did not work in Linux.
> > Is anyone aware of any network driver that successfully uses fragmented
> > SKBs?
> 
> Raghavendra Koushik wrote:
> > I did try fragmented SKB on Rx but it didn't seem to work. If any one
> can
> > give me some pointers on how to get this working, I would implement
> 2Buff
> > mode using this method and avoid a copy in fast path.
> 
> 
> 
> My suggestion would be to investigate why fragmented SKBs don't work ;-)
> 
> The source code is all there, debug away...
> 
> If S2IO can fix this, a lot of people will benefit.
> 
>       Jeff



<Prev in Thread] Current Thread [Next in Thread>