| To: | Ganesh Venkatesan <ganesh.venkatesan@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Patch 12/16 2.5] ixgb: replace kmalloc with vmalloc to allocate driver local data structures |
| From: | Christian Borntraeger <linux-kernel@xxxxxxxxxxxxxxx> |
| Date: | Fri, 15 Oct 2004 18:46:42 +0200 |
| Cc: | "jgarzik@xxxxxxxxx" <jgarzik@xxxxxxxxx>, netdev <netdev@xxxxxxxxxxx> |
| In-reply-to: | <Pine.LNX.4.44.0410150638490.31227-100000@isotope.jf.intel.com> |
| References: | <Pine.LNX.4.44.0410150638490.31227-100000@isotope.jf.intel.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | KMail/1.7 |
Ganesh Venkatesan wrote: > - rxdr->buffer_info = kmalloc(size, GFP_KERNEL); [...] > + rxdr->buffer_info = vmalloc(size); What is the rationale for this change? If I recall correctly, Linus opposes the use of vmalloc if there is no real need. cheers Christian |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Patch 0/5 2.4] e1000: driver update, Jeff Garzik |
|---|---|
| Next by Date: | Re: [Patch 0/5 2.5] e1000: driver update, Jeff Garzik |
| Previous by Thread: | [Patch 12/16 2.5] ixgb: replace kmalloc with vmalloc to allocate driver local data structures, Ganesh Venkatesan |
| Next by Thread: | RE: [Patch 12/16 2.5] ixgb: replace kmalloc with vmalloc to allocate driver local data structures, Venkatesan, Ganesh |
| Indexes: | [Date] [Thread] [Top] [All Lists] |