netdev
[Top] [All Lists]

Re: [PATCH 2.6.9-rc4-mm1] [m32r] Fix smc91x driver for m32r

To: jgarzik@xxxxxxxxx
Subject: Re: [PATCH 2.6.9-rc4-mm1] [m32r] Fix smc91x driver for m32r
From: Hirokazu Takata <takata@xxxxxxxxxxxxxx>
Date: Wed, 13 Oct 2004 10:52:43 +0900 (JST)
Cc: akpm@xxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Paul Mundt <paul.mundt@xxxxxxxxx>, Nicolas Pitre <nico@xxxxxxx>, netdev@xxxxxxxxxxx, takata@xxxxxxxxxxxxxx
In-reply-to: <416BFD79.1010306@pobox.com>
References: <20041012.195043.137811384.takata.hirokazu@renesas.com> <416BFD79.1010306@pobox.com>
Sender: netdev-bounce@xxxxxxxxxxx
Hello,

Sorry, I've changed my mind, according to the thread of 
"[PATCH] net: fix smc91x build for sh/ppc" (Oct 12, 2004).
I prefer that set_irq_type() is snipped by CONFIG_ARM, too.

Please throw away this patch and retrieve the previous 
m32r-trivial-fix-of-smc91xh.patch again, 
if the above patch "[PATCH] net: fix smc91x build for sh/ppc" is applied.

Thank you.


From: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: [PATCH 2.6.9-rc4-mm1] [m32r] Fix smc91x driver for m32r
Date: Tue, 12 Oct 2004 11:51:21 -0400
> Hirokazu Takata wrote:
> > Just fix compile error of drivers/net/smc91x.c for m32r.
> > 
> > It seems the previous patch (m32r-trivial-fix-of-smc91xh.patch) is too old. 
> > So I will send a new patch.
> > 
> > Please drop the previous patch
> > ( $ patch -R1 -p1 <m32r-trivial-fix-of-smc91xh.patch )
> > and apply the new one.
> > 
> >     * drivers/net/smc91x.h:
> >     - Add set_irq_type() macro to ignore it for m32r.
> >     - Fix RPC_LSA_DEFAULT and RPC_LSB_DEFAULT for an M3T-M32700UT board.
> > 
> > Thanks.
> > 
> > Signed-off-by: Hirokazu Takata <takata@xxxxxxxxxxxxxx>
> 
> Seems OK to me, I'll put it into my netdev queue.
> 
> For net driver patches, please always CC
> * netdev@xxxxxxxxxxx, and
> * jgarzik@xxxxxxxxx
> 
>       Jeff

-- Takata

<Prev in Thread] Current Thread [Next in Thread>