netdev
[Top] [All Lists]

Re: [PATCH] Prevent netpoll hanging when link is down

To: Matt Mackall <mpm@xxxxxxxxxxx>
Subject: Re: [PATCH] Prevent netpoll hanging when link is down
From: Andi Kleen <ak@xxxxxxx>
Date: Mon, 11 Oct 2004 18:43:15 +0200
Cc: Andi Kleen <ak@xxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, colin@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20041011163601.GM31237@waste.org>
References: <20041007224422.1c1bea95@jack.colino.net> <20041007214505.GB31558@wotan.suse.de> <20041008090610.70d7e183@pirandello> <20041008220001.GE31237@waste.org> <20041008151839.01823e0c.akpm@osdl.org> <20041010205928.6e54df7e.davem@davemloft.net> <20041011154000.GB26350@wotan.suse.de> <20041011162224.GL31237@waste.org> <20041011163226.GG26350@wotan.suse.de> <20041011163601.GM31237@waste.org>
Sender: netdev-bounce@xxxxxxxxxxx
> It's not recursion on printk that's a problem, it's recursion on
> ->poll() and attempting to take whatever internal driver locks.

There is no recursion on poll because printk will never call into
the low level console driver when the console sem is already taken.

-Andi

P.S.: I made the same mistake long ago, but akpm set me straight.


<Prev in Thread] Current Thread [Next in Thread>