| To: | Pavel Roskin <proski@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h |
| From: | viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx |
| Date: | Mon, 11 Oct 2004 15:04:54 +0100 |
| Cc: | Cal Peake <cp@xxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, David Gibson <hermes@xxxxxxxxxxxxxxxxxxxxx> |
| In-reply-to: | <Pine.LNX.4.61.0410110858350.4733@portland.hansa.lan> |
| References: | <Pine.LNX.4.61.0410110702590.7899@linaeum.absolutedigital.net> <Pine.LNX.4.61.0410110858350.4733@portland.hansa.lan> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.1i |
On Mon, Oct 11, 2004 at 09:12:03AM -0400, Pavel Roskin wrote:
> Another, more sophisticated solution would be to use union for iobase:
>
> typedef struct hermes {
> union {
> unsigned long io;
> void *mem;
> } base;
> int io_space; /* 1 if we IO-mapped IO, 0 for memory-mapped IO? */
> ...
> }
Not needed. Use ioread*/iowrite* family; it does what you need.
Al, putting together a patchset and documention on that sort of cleanups...
|
| Previous by Date: | Re: [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h, Pavel Roskin |
|---|---|
| Next by Date: | Re: [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h, Cal Peake |
| Previous by Thread: | Re: [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h, Pavel Roskin |
| Next by Thread: | patch: Mirred action, jamal |
| Indexes: | [Date] [Thread] [Top] [All Lists] |