netdev
[Top] [All Lists]

Re: [PATCH]: fixed typo of reassembly.c

To: Yasuyuki Kozakai <yasuyuki.kozakai@xxxxxxxxxxxxx>
Subject: Re: [PATCH]: fixed typo of reassembly.c
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Fri, 1 Oct 2004 15:19:23 -0700
Cc: netdev@xxxxxxxxxxx, usagi-core@xxxxxxxxxxxxxx
In-reply-to: <200409301023.i8UANRGp002783@toshiba.co.jp>
References: <200409301023.i8UANRGp002783@toshiba.co.jp>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 30 Sep 2004 19:23:26 +0900 (JST)
Yasuyuki Kozakai <yasuyuki.kozakai@xxxxxxxxxxxxx> wrote:

> This patch fixes byte ordering. Please apply this.

It is textual fix only, do you realize this?
Both ntohs() and htons() perform the same transformation
on a 16-bit data item.  It really does not matter which
one you actually use, in practice.

I will apply your patch anyways, I just wanted to be
clear that this does not actually fix any bug. :-)

THanks.

<Prev in Thread] Current Thread [Next in Thread>