Re: [PATCH] Improve behaviour of Netlink Sockets

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Tue, Sep 28, 2004 at 11:07:04PM +0200, Pablo Neira wrote:
> 
> If buffer overruns we lost all the messages which are enqueued, so 

This is not true.  You will get an ENOBUFS error but the packets
that have already been queued are still on the queue if you want
to read them.

> ===== net/netlink/af_netlink.c 1.58 vs edited =====
> --- 1.58/net/netlink/af_netlink.c     Sat Sep 25 17:43:43 2004
> +++ edited/net/netlink/af_netlink.c   Tue Sep 28 22:23:44 2004
> @@ -475,7 +475,7 @@
>       if (nlk->handler)
>               return 0;
>  #endif
> -     if (atomic_read(&sk->sk_rmem_alloc) > sk->sk_rcvbuf ||
> +     if (atomic_read(&sk->sk_rmem_alloc) + skb->len > sk->sk_rcvbuf ||

I don't see the point of this patch.  All it does is make the overrun
happen one packet earlier.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt