| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: bad TSO performance in 2.6.9-rc2-BK |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Tue, 28 Sep 2004 07:32:33 +1000 |
| Cc: | ak@xxxxxxx, niv@xxxxxxxxxx, andy.grover@xxxxxxxxx, anton@xxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20040927120154.09fdcadf.davem@davemloft.net> |
| References: | <20040923164149.5368d291.davem@davemloft.net> <E1CBkIW-0001dF-00@gondolin.me.apana.org.au> <20040927025048.GA6723@gondor.apana.org.au> <20040926210029.22750d47.davem@davemloft.net> <20040927054541.GA8858@gondor.apana.org.au> <20040927120154.09fdcadf.davem@davemloft.net> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040722i |
On Mon, Sep 27, 2004 at 12:01:54PM -0700, David S. Miller wrote: > > > tcp_current_mss() doesn't call tcp_sync_mss() unless the PMTU changes. > > Good catch, probably we should make it do so when sk_route_caps > indicates we are doing TSO. Alternatively we could move the TSO code out of tcp_sync_mss() and put it in tcp_current_mss() instead. It seems to be the only one using the factor anyway. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt |
| Previous by Date: | Re: Set truesize in pskb_expand_head, Herbert Xu |
|---|---|
| Next by Date: | Re: [PATCH] Improve behaviour of Netlink Sockets, Herbert Xu |
| Previous by Thread: | Re: bad TSO performance in 2.6.9-rc2-BK, David S. Miller |
| Next by Thread: | Re: bad TSO performance in 2.6.9-rc2-BK, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |