Re: [PATCH 2.6] neighbour cache statistics like rt_stat

["David S. Miller" <davem@xxxxxxxxxxxxx>]

On Mon, 27 Sep 2004 18:23:34 +0200
Harald Welte <laforge@xxxxxxxxxxxx> wrote:

> On Mon, Sep 27, 2004 at 11:36:13AM +0200, Harald Welte wrote:
> > The patch below (on top of davem's recent 6-patch set and 4-patch-set up
> > to diff4) adds rt_stat like statistics to the neighbour cache core.
> 
> I've now updated the patch.
> 
> Changes:
>       - more statistics (lookups, destroy, periodic_gc_runs)
>       - add template line to top of file

I'm generally very happy with these changes, but two things:

1) Please update the patch since I replaced "diff4" with
   a patch simply removing the INCOMPLETE checks from neigh_forced_gc()

2) I'd recommend using unsigned long for all the statistics.

Thanks.