The patch below (on top of davem's recent 6-patch set and 4-patch-set up
to diff4) adds rt_stat like statistics to the neighbour cache core.
It helped a lot during debugging/testing, and I think it is generally
useful for the mainline kernel if you want to do runtime analysis of
neighbour cahce performance / problems.
Some comments/questions/ideas
1) old statistics used to be unsigned long, new ones are int. I propose
to convert all of them to int.
2) I'd also like to add gc statistics on non-forced-gc but normal
garbage collection.
3) Do we need a seperate 'miss' counter, or is the 'allocs' counter
sufficient?
4) Don't we want to put them in a /proc/net/neigh directory ?
5) Since there's now rt_stat, ct_stat, neighbour statistics, and they
all use the same clumsy format that is difficult to expand, and all
use copy+paste userspace tools: Would you accept a patch that changes
the format once again to display a template as first line, giving the
names of the individual fields? I would then work on a generic
userspace tool (too bad that the name netstat is already used) that
would work with all of those _stat files, including upcoming new
ones.
--
- Harald Welte <laforge@xxxxxxxxxxxx> http://www.gnumonks.org/
============================================================================
Programming is like sex: One mistake and you have to support it your lifetime
laforge-neigh_statistics.patch
Description: Text document
signature.asc
Description: Digital signature
|