| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] Improve behaviour of Netlink Sockets |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Sat, 25 Sep 2004 08:28:03 +1000 |
| Cc: | pablo@xxxxxxxxxxx, hadi@xxxxxxxxxx, davem@xxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20040924220651.GA6096@gondor.apana.org.au> |
| References: | <20040922045239.GA19573@gondor.apana.org.au> <1095854920.1047.64.camel@jzny.localdomain> <20040922105221.59a67d4b.davem@davemloft.net> <4152EE68.4030803@eurodev.net> <20040923121651.51a58cf2.davem@davemloft.net> <20040924032830.GC6384@gondor.apana.org.au> <20040923223909.6f4da27f.davem@davemloft.net> <20040924062604.GA7393@gondor.apana.org.au> <20040924105855.0e1aecd0.davem@davemloft.net> <20040924220651.GA6096@gondor.apana.org.au> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040722i |
On Sat, Sep 25, 2004 at 08:06:51AM +1000, herbert wrote: > > I agree completely. I'm just saying that the current NLM_GOODSIZE > skb is the perfect scratch-pad so we don't need a new one. All we > need to do is to insert a helper call just before netlink_unicast > to copy and trim the packet in the places that need it. Here is a demonstration of what I meant. Please note that this is totally untested. We could just make the last argument of netlink_unicast into a flag so that it can do this directly. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
|
| Previous by Date: | Re: [PATCH] Improve behaviour of Netlink Sockets, Herbert Xu |
|---|---|
| Next by Date: | Set truesize in pskb_expand_head, Herbert Xu |
| Previous by Thread: | Re: [PATCH] Improve behaviour of Netlink Sockets, Herbert Xu |
| Next by Thread: | Re: [PATCH] Improve behaviour of Netlink Sockets, jamal |
| Indexes: | [Date] [Thread] [Top] [All Lists] |