| To: | Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/2 2.6] e100: fix NAPI race with watchdog |
| From: | Stephen Hemminger <shemminger@xxxxxxxx> |
| Date: | Wed, 22 Sep 2004 13:38:23 -0700 |
| Cc: | jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <Pine.LNX.4.44.0409221217010.7544-100000@isotope.jf.intel.com> |
| Organization: | Open Source Development Lab |
| References: | <Pine.LNX.4.44.0409221217010.7544-100000@isotope.jf.intel.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Wed, 22 Sep 2004 12:25:44 -0700 (PDT) Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx> wrote: > While polling in NAPI mode, we were occassionally getting interrupts > re-enabled by the watchdog trying to generate a software interrupt. Fix > is to add a spinlock around that shared hardware register to allow a > read-modify-write operation. This was nasty nasty. I don't like the > spinlock in the hot path but i see no other way. Comments are welcome. > Updates the driver version as well. You could convert it to LLTX then at least there is only one lock roundtrip |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: bad TSO performance in 2.6.9-rc2-BK, David S. Miller |
|---|---|
| Next by Date: | Re: bad TSO performance in 2.6.9-rc2-BK, David S. Miller |
| Previous by Thread: | [PATCH 1/2 2.6] e100: fix NAPI race with watchdog, Jesse Brandeburg |
| Next by Thread: | Re: [PATCH 1/2 2.6] e100: fix NAPI race with watchdog, James Chapman |
| Indexes: | [Date] [Thread] [Top] [All Lists] |