On Wed, 22 Sep 2004 12:07:29 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Sep 20, 2004 at 11:18:05PM -0700, David S. Miller wrote:
> >
> > > Yes CONFIG_IP_ROUTE_TOS has out-lived its usefulness. It has
> > > always seemed half-hearted compared to CONFIG_IP_ROUTE_FWMARK.
> >
> > Ok, then I'm gonna nuke it.
>
> Here is a follow-up patch to get rid of the remaining Kconfig references.
>
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
I'll apply this, thanks Herbert.
Dang, right after pushing the fib_hash.c cleanup to Linus
I spotted this bug :-/
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/09/21 16:32:41-07:00 davem@xxxxxxxxxxxxxxxxxx
# [IPV4]: Fix list traversal in fn_hash_insert().
#
# Could create an endless loop during route
# replace operations.
#
# Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
#
# net/ipv4/fib_hash.c
# 2004/09/21 16:31:48-07:00 davem@xxxxxxxxxxxxxxxxxx +1 -1
# [IPV4]: Fix list traversal in fn_hash_insert().
#
diff -Nru a/net/ipv4/fib_hash.c b/net/ipv4/fib_hash.c
--- a/net/ipv4/fib_hash.c 2004-09-21 19:11:44 -07:00
+++ b/net/ipv4/fib_hash.c 2004-09-21 19:11:44 -07:00
@@ -536,7 +536,7 @@
* information.
*/
fa_orig = fa;
- list_for_each_entry(fa, fa->fa_list.prev, fa_list) {
+ list_for_each_entry(fa, fa_orig->fa_list.prev, fa_list) {
if (fa->fa_info->fib_priority != fi->fib_priority)
break;
if (fa->fa_type == type &&
|