Re: [PATCH] Clean up fib_hash datastructures

[Andi Kleen <ak@xxxxxxx>]

On Mon, Sep 20, 2004 at 11:18:05PM -0700, David S. Miller wrote:
> On Tue, 21 Sep 2004 13:42:12 +1000
> Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > On Mon, Sep 20, 2004 at 07:11:23PM +0000, David S. Miller wrote:
> > > 
> > > I believe I was successful in preserving existing behavior, but
> > > I wonder if it makes sense any longer.  CONFIG_IP_ROUTE_TOS
> > > changes not one data structure.  It does exactly:
> > 
> > Yes CONFIG_IP_ROUTE_TOS has out-lived its usefulness.  It has
> > always seemed half-hearted compared to CONFIG_IP_ROUTE_FWMARK.
> 
> Ok, then I'm gonna nuke it.

Hmm, are you removing TOS support completely or just remove the
CONFIG and always enable the code? 

[Somehow it looks to me like you and Herbert are miscommunicating ;-]

I think you should remove the TOS support completely because
it's obsolete with fwmark.  And maybe remove it will allow
some tuning later.

-Andi